Mamanyonyo/atrooney-online-2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #19 from LeifaBot/master

Browse Source 
Fix buffer overflow exploit
This commit is contained in:
oldmud0 2018-07-04 10:53:31 -04:00 committed by GitHub
commit e761805cd1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
networkmanager.cpp
View File

@ -4,6 +4,7 @@
#include "debug_functions.h"
#include "lobby.h"
#include <cstring>
NetworkManager::NetworkManager(AOApplication *parent) : QObject(parent)
{
@ -75,8 +76,9 @@ void NetworkManager::ship_server_packet(QString p_packet)
void NetworkManager::handle_ms_packet()
{
char buffer[16384] = {0};
ms_socket->read(buffer, ms_socket->bytesAvailable());
char buffer[buffer_max_size];
std::memset(buffer, 0, buffer_max_size);
ms_socket->read(buffer, buffer_max_size);
QString in_data = buffer;
@ -100,7 +102,7 @@ void NetworkManager::handle_ms_packet()
QStringList packet_list = in_data.split("%", QString::SplitBehavior(QString::SkipEmptyParts));
for (QString packet : packet_list)
{
{
AOPacket *f_packet = new AOPacket(packet);
ao_app->ms_packet_received(f_packet);
@ -213,8 +215,9 @@ void NetworkManager::retry_ms_connect()
void NetworkManager::handle_server_packet()
{
char buffer[16384] = {0};
server_socket->read(buffer, server_socket->bytesAvailable());
char buffer[buffer_max_size];
std::memset(buffer, 0, buffer_max_size);
server_socket->read(buffer, buffer_max_size);
QString in_data = buffer;

3
networkmanager.h
View File

@ -48,6 +48,9 @@ public:
const int ms_reconnect_delay_ms = 7000;
// kind of arbitrary max buffer size
const size_t buffer_max_size = 16384;
bool ms_partial_packet = false;
QString ms_temp_packet = "";