Mamanyonyo/atrooney-online-2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Resolve a segfault with screenshake, need to determine a better method to finish previous animation (if it exists) properly.

Browse Source
This commit is contained in:
Crystalwarrior 2019-09-14 01:20:01 +03:00
parent 4b452e968d
commit b608f84100
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/courtroom.cpp
View File

@ -1656,21 +1656,24 @@ void Courtroom::handle_chatmessage_2()
void Courtroom::do_screenshake() void Courtroom::do_screenshake()
{ {
if (screenshake_animation_group && screenshake_animation_group->state() == QAbstractAnimation::Running) //Code below causes segfault, do not uncomment unless you know what you're doing.
screenshake_animation_group->setCurrentTime(screenshake_animation_group->duration()); //Force it to finish and delete itself // if (screenshake_animation_group != nullptr && screenshake_animation_group->state() == QAbstractAnimation::Running)
// screenshake_animation_group->setCurrentTime(screenshake_animation_group->duration()); //Force it to finish and delete itself
screenshake_animation_group = new QParallelAnimationGroup; screenshake_animation_group = new QParallelAnimationGroup;
QList<QWidget*> affected_list = { QList<QWidget *> affected_list = {
ui_vp_background, ui_vp_background,
ui_vp_player_char, ui_vp_player_char,
ui_vp_sideplayer_char, ui_vp_sideplayer_char,
ui_vp_chatbox, ui_vp_chatbox
}; };
int i = 0;
//I would prefer if this was its own "shake" function to be honest. //I would prefer if this was its own "shake" function to be honest.
foreach (QWidget* ui_element, affected_list) foreach (QWidget* ui_element, affected_list)
{ {
qDebug() << ++i;
QPropertyAnimation *screenshake_animation = new QPropertyAnimation(ui_element, "pos", this); QPropertyAnimation *screenshake_animation = new QPropertyAnimation(ui_element, "pos", this);
QPoint pos_default = QPoint(ui_element->x(), ui_element->y()); QPoint pos_default = QPoint(ui_element->x(), ui_element->y());