From 48675f00d065739d08854f8bf1a36bb87758e7db Mon Sep 17 00:00:00 2001 From: oldmud0 Date: Sat, 22 Aug 2020 15:17:48 -0500 Subject: [PATCH 1/2] Fix upward log scrolling down instead of up Stop using upwards log. Seriously. No other program does this. --- src/courtroom.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/courtroom.cpp b/src/courtroom.cpp index 2484bcb..04c625f 100644 --- a/src/courtroom.cpp +++ b/src/courtroom.cpp @@ -2660,7 +2660,8 @@ void Courtroom::append_ic_text(QString p_text, QString p_name, QString p_action, // scroll to the bottom. ui_ic_chatlog->moveCursor(log_goes_downwards ? QTextCursor::End : QTextCursor::Start); ui_ic_chatlog->verticalScrollBar()->setValue( - ui_ic_chatlog->verticalScrollBar()->maximum()); + log_goes_downwards ? ui_ic_chatlog->verticalScrollBar()->maximum() + : 0); } } From 8dcddf289f2528d8720e89c05857969c721ed559 Mon Sep 17 00:00:00 2001 From: oldmud0 Date: Sat, 22 Aug 2020 15:33:08 -0500 Subject: [PATCH 2/2] Only reinitialize audio on device change --- src/aooptionsdialog.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/aooptionsdialog.cpp b/src/aooptionsdialog.cpp index 6fc4d03..4d36f43 100644 --- a/src/aooptionsdialog.cpp +++ b/src/aooptionsdialog.cpp @@ -756,6 +756,9 @@ void AOOptionsDialog::save_pressed() // Save everything into the config.ini. QSettings *configini = ao_app->configini; + const bool audioChanged = ui_audio_device_combobox->currentText() != + ao_app->get_audio_output_device(); + configini->setValue("theme", ui_theme_combobox->currentText()); configini->setValue("log_goes_downwards", ui_downwards_cb->isChecked()); configini->setValue("log_maximum", ui_length_spinbox->value()); @@ -806,7 +809,9 @@ void AOOptionsDialog::save_pressed() configini->setValue("casing_can_host_cases", ui_casing_cm_cases_textbox->text()); - ao_app->initBASS(); + if (audioChanged) + ao_app->initBASS(); + callwordsini->close(); done(0); }