From 501f2a9dd029519af9d4ad7e298785b5575a1584 Mon Sep 17 00:00:00 2001
From: in1tiate <32779090+in1tiate@users.noreply.github.com>
Date: Sat, 11 Jan 2025 02:16:10 -0600
Subject: [PATCH] fix static regexps
---
src/lobby.cpp | 4 +++-
src/lobby.h | 2 --
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/lobby.cpp b/src/lobby.cpp
index 9a6d802..5e98b75 100644
--- a/src/lobby.cpp
+++ b/src/lobby.cpp
@@ -20,7 +20,6 @@ Lobby::Lobby(AOApplication *p_ao_app, NetworkManager *p_net_manager)
{
reloadUi();
setObjectName("lobby");
- regexp_links = QRegularExpression("\\b(https?://\\S+\\.\\S+)\\b");
}
void Lobby::on_tab_changed(int index)
@@ -564,6 +563,8 @@ void Lobby::check_for_updates()
QVersionNumber current_version = QVersionNumber::fromString(ao_app->get_version_string());
QVersionNumber master_version = QVersionNumber::fromString(version);
+ static QRegularExpression regexp_links("\\b(https?://\\S+\\.\\S+)\\b");
+
if (current_version < master_version)
{
ui_game_version_lbl->setText(tr("Version: %1 [OUTDATED]").arg(current_version.toString()));
@@ -584,6 +585,7 @@ void Lobby::set_player_count(int players_online, int max_players)
void Lobby::set_server_description(const QString &server_description)
{
ui_server_description_text->clear();
+ static QRegularExpression regexp_links("\\b(https?://\\S+\\.\\S+)\\b");
QString result = server_description.toHtmlEscaped().replace("\n", "
").replace(regexp_links, "\\1");
ui_server_description_text->insertHtml(result);
}
diff --git a/src/lobby.h b/src/lobby.h
index 347d406..8b894f4 100644
--- a/src/lobby.h
+++ b/src/lobby.h
@@ -91,8 +91,6 @@ private:
// Optional Widget
QTextBrowser *ui_game_changelog_text;
- static QRegularExpression regexp_links;
-
void loadUI();
void reloadUi();