Merge pull request #56 from OmniTroid/master

Small fixes, decluttering + better build scripts

Attorney_Online.pro

@@ -1,16 +1,9 @@
-#-------------------------------------------------
-#
-# Project created by QtCreator 2016-12-29T01:14:46
-#
-#-------------------------------------------------
-
-QT       += core gui multimedia network
-greaterThan(QT_MAJOR_VERSION, 4): QT += widgets
+QT += core gui widgets multimedia network
 
 TARGET = Attorney_Online
 TEMPLATE = app
 
-VERSION = 2.6.0.0
+VERSION = 2.6.1.0
 
 INCLUDEPATH += $$PWD/include
 DESTDIR = $$PWD/bin
@@ -26,5 +19,4 @@ CONFIG += c++11
 RESOURCES += resources.qrc
 
 win32:RC_ICONS = resource/logo.ico
-
-QTPLUGIN += qapng
+macx:ICON = resource/logo.icns

scripts/fix_dynamic_linking_macos.sh

@@ -1,16 +0,0 @@
-#!/bin/bash
-
-#this script relinks dynamic libraries so the .app file can be distributed as standalone
-
-install_name_tool -id @executable_path/../Frameworks/libbass.dylib ../bin/Attorney_Online.app/Contents/Frameworks/libbass.dylib
-
-install_name_tool -id @executable_path/../Frameworks/libbassopus.dylib ../bin/Attorney_Online.app/Contents/Frameworks/libbassopus.dylib
-
-install_name_tool -id @executable_path/../Frameworks/libdiscord-rpc.dylib ../bin/Attorney_Online.app/Contents/Frameworks/libdiscord-rpc.dylib
-
-install_name_tool -id @executable_path/../Frameworks/libqapng.dylib ../bin/Attorney_Online.app/Contents/Frameworks/libqapng.dylib
-
-install_name_tool -change @loader_path/libbass.dylib @executable_path/../Frameworks/libbass.dylib ../bin/Attorney_Online.app/Contents/MacOS/Attorney_Online
-
-install_name_tool -change @rpath/libdiscord-rpc.dylib @executable_path/../Frameworks/libdiscord-rpc.dylib ../bin/Attorney_Online.app/Contents/MacOS/Attorney_Online
-

scripts/macos_post_build.sh

@@ -0,0 +1,16 @@
+#!/bin/bash
+
+DST_FOLDER="./bin/Attorney_Online.app/Contents/Frameworks"
+
+cd ..
+
+mkdir $DST_FOLDER
+
+cp ./lib/libbass.dylib $DST_FOLDER
+cp ./lib/libbassopus.dylib $DST_FOLDER
+
+install_name_tool -id @executable_path/../Frameworks/libbass.dylib $DST_FOLDER/libbass.dylib
+
+install_name_tool -id @executable_path/../Frameworks/libbassopus.dylib $DST_FOLDER/libbassopus.dylib
+
+install_name_tool -change @loader_path/libbass.dylib @executable_path/../Frameworks/libbass.dylib ./bin/Attorney_Online.app/Contents/MacOS/Attorney_Online

src/courtroom.cpp

@@ -3511,7 +3511,10 @@ void Courtroom::load_bass_opus_plugin()
 #elif defined __APPLE__
 void Courtroom::load_bass_opus_plugin()
 {
-  BASS_PluginLoad("libbassopus.dylib", 0);
+  QString libpath = ao_app->get_base_path() + "../../Frameworks/libbassopus.dylib";
+  QByteArray ba = libpath.toLocal8Bit();
+
+  BASS_PluginLoad(ba.data(), 0);
 }
 #else
 #error This operating system is unsupported for bass plugins.

src/text_file_functions.cpp

@@ -9,6 +9,10 @@ QString AOApplication::read_theme()
 int AOApplication::read_blip_rate()
 {
   int result = configini->value("blip_rate", 1).toInt();
+
+  if (result < 1)
+    return 1;
+
   return result;
 }