Merge pull request #125 from AttorneyOnline/ban-updating

Add /updateban

core/include/aoclient.h

@@ -1202,6 +1202,17 @@ class AOClient : public QObject {
      */
     void cmdKickUid(int argc, QStringList argv);
 
+    /**
+     * @brief Updates a ban in the database, changing either its reason or duration.
+     *
+     * @details The first argument is the **ID** of the ban to update. The second argument is the **field** to update, either `reason` or `duration`
+     *
+     * and the remaining arguments are the **duration** or the **reason** to update to.
+     *
+     * @iscommand
+     */
+    void cmdUpdateBan(int argc, QStringList argv);
+
     ///@}
 
     /**
@@ -2024,6 +2035,8 @@ class AOClient : public QObject {
         {"kickuid",            {ACLFlags.value("KICK"),         2, &AOClient::cmdKickUid}},
         {"kick_uid",           {ACLFlags.value("KICK"),         2, &AOClient::cmdKickUid}},
         {"firstperson",        {ACLFlags.value("NONE"),         0, &AOClient::cmdFirstPerson}},
+        {"updateban",          {ACLFlags.value("BAN"),          3, &AOClient::cmdUpdateBan}},
+        {"update_ban",         {ACLFlags.value("BAN"),          3, &AOClient::cmdUpdateBan}},
         {"changepass",         {ACLFlags.value("NONE"),         1, &AOClient::cmdChangePassword}},
     };
 

core/include/db_manager.h

@@ -252,6 +252,19 @@ public:
      */
     QList<BanInfo> getBanInfo(QString lookup_type, QString id);
 
+    /**
+     * @brief Updates a ban.
+     *
+     * @param ban_id The ID of the ban to update.
+     *
+     * @param field The field to update, either "reason" or "duration".
+     *
+     * @param updated_info The info to update the field to.
+     *
+     * @return True if the modification was successful.
+     */
+    bool updateBan(int ban_id, QString field, QVariant updated_info);
+
     /**
      * @brief Updates the password of the given user.
      *

core/src/commands/moderation.cpp

@@ -467,3 +467,45 @@ void AOClient::cmdKickUid(int argc, QStringList argv)
     target->socket->close();
     sendServerMessage("Kicked client with UID " + argv[0] + " for reason: " + reason);
 }
+
+void AOClient::cmdUpdateBan(int argc, QStringList argv)
+{
+    bool conv_ok = false;
+    int ban_id = argv[0].toInt(&conv_ok);
+    if (!conv_ok) {
+        sendServerMessage("Invalid ban ID.");
+        return;
+    }
+    QVariant updated_info;
+    if (argv[1] == "duration") {
+        long long duration_seconds = 0;
+        if (argv[2] == "perma")
+            duration_seconds = -2;
+        else
+            duration_seconds = parseTime(argv[2]);
+
+        if (duration_seconds == -1) {
+            sendServerMessage("Invalid time format. Format example: 1h30m");
+            return;
+        }
+        updated_info = QVariant(duration_seconds);
+
+    }
+    else if (argv[1] == "reason") {
+        QString args_str = argv[2];
+        if (argc > 3) {
+            for (int i = 3; i < argc; i++)
+                args_str += " " + argv[i];
+        }
+        updated_info = QVariant(args_str);
+    }
+    else {
+        sendServerMessage("Invalid update type.");
+        return;
+    }
+    if (!server->db_manager->updateBan(ban_id, argv[1], updated_info)) {
+        sendServerMessage("There was an error updating the ban. Please confirm the ban ID is valid.");
+        return;
+    }
+    sendServerMessage("Ban updated.");
+}

core/src/db_manager.cpp

@@ -368,6 +368,27 @@ QList<DBManager::BanInfo> DBManager::getBanInfo(QString lookup_type, QString id)
     return return_list;
 }
 
+bool DBManager::updateBan(int ban_id, QString field, QVariant updated_info)
+{
+    QSqlQuery query;
+    if (field == "reason") {
+        query.prepare("UPDATE bans SET REASON = ? WHERE ID = ?");
+        query.addBindValue(updated_info.toString());
+    }
+    else if (field == "duration") {
+        query.prepare("UPDATE bans SET DURATION = ? WHERE ID = ?");
+        query.addBindValue(updated_info.toLongLong());
+    }
+    query.addBindValue(ban_id);
+    if (!query.exec()) {
+        qDebug() << query.lastError();
+        return false;
+    }
+    else {
+        return true;
+    }
+}
+
 bool DBManager::updatePassword(QString username, QString password)
 {
     QString salt;